style: centered keyword items in the packages card#854
style: centered keyword items in the packages card#854danielroe merged 2 commits intonpmx-dev:mainfrom
Conversation
📝 WalkthroughWalkthroughThis pull request updates the Package Card component template to add the CSS class 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
There was a problem hiding this comment.
Thanks for this fix @MhemedAbderrahmen! I took a look on macOS with Firefox, Chrome, and Safari, and it looks good: the vertical centering is consistent regardless of the number of items or lines of content.
However, the PR's title should be updated to follow the Conventional Commits. It's used as the commit message when the PR is merged.
More info at https://github.com/npmx-dev/npmx.dev/blob/main/CONTRIBUTING.md#commit-messages-and-pr-titles.
It could be something like `fix: vertically centered package card keywords" instead.
(I'm not part of the core team, but offered to help with pre-reviews on Discord)
This is a simple PR to fix a slight styling issue on the package card when searching


Current style
Fixed style: